-
Notifications
You must be signed in to change notification settings - Fork 782
Conversation
This PR contains all the work that was done for #584, #1081, #1028 and #1021. I have tried to clean it all up, get the tests working, have stuff removed that is not possible to add to ESH due to the license (MaryTTS, PocketSphinx, etc.). @hkuhn42 Would be great to have you reviewing this or at least that you familiarize yourself with it and see how/if you can further contribute to it (Kelly&Co unfortunately stopped working on it). I shuffled around the interfaces a bit and decided to put the voice stuff now directly under core.voice and have the audio interfaces in the core bundle itself, so that issues like #1200 can be easily implemented without any optional dependencies. |
@maggu2810 FTR: This PR is more than 1000 lines and has contributions from others, so we will require a CQ for it. Once you and @hkuhn42 have given a lgtm, I will create a CQ for it. |
Travic CI failed:
|
Weird, somehow all the new MANIFESTs are not shown (and added) in git... |
Not sure how the failing tests could potentially be related to this PR...? |
I will try to have a look into it tomorrow |
*/ | ||
public class VoiceManager { | ||
|
||
private static final Logger logger = LoggerFactory.getLogger(VoiceManager.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is only one static method but that method does not use the logger. We could use a non-static logger
thanks @maggu2810 I have updated the PR. |
- Created audio API in smarthome.core - Introduced smarthome.core.voice for TTS, STT and HLI APIs - Introduced smarthome.io.javasound for audio implementations based on Java Sound API - Introduced smarthome.voice.mactts as a Mac specific TTS implementation Also-By: Harald Kuhn <harald.kuhn@gmail.com> Also-By: Kelly Davis <kdavis@mozilla.com> Also-By: Tilman Kamp <tilmankamp@posteo.de> Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Tests are green now. |
@kaikreuzer no more immediate comments. Please create the cq. I will need a bit more time to have an in depth look as i have to setup a new development environment first. |
Thanks for the feedback, @hkuhn42. I have now created CQ 11705 and will wait for its approval. |
CQ is approved, hence I merge this now. |
@kaikreuzer any hints on where to start using the HLI interfaces? I found what looks to be the reference implementation (StandardInterpreter) but could not use it in my test bundle as it's not an Export-Package. Then I tried to create my own class that implements HumanLanguageInterpreter but despite adding the Import-Package I received the following:
|
Well, here the package is exported, so it should be available to you. In case you are using the openHAB 2 IDE, please note that I just release an ESH build that includes this PR tonight, so before it wasn't part of the target platform of openHAB. |
Also-By: Harald Kuhn harald.kuhn@gmail.com
Also-By: Kelly Davis kdavis@mozilla.com
Also-By: Tilman Kamp tilmankamp@posteo.de
Signed-off-by: Kai Kreuzer kai@openhab.org